Bug: Flash - if no flashvars are given / iframe
-
Hi,
Just found some Bugs recently:
1) This Bug appears already in Version prettyPhoto_uncompressed_2.4.3
If you want to open a Flash file in the Overlay it is marked as flash - Flash Case (Line 254)
If there are no flashparams indexof('flashvars') is giving back -1. In this case we have -1+10 characters and then to the end of the given url.
Which means on your demo page Flash Content Demo
First link:
http://www.adobe.com/products/flashplayer/include/marquee/design.swf&?width=792&height=294
NO Flashvar - which means you get following url in your Flash Object:
http://www.adobe.com/products/flashplayer/include/marquee/design.swf?w.adobe.com/products/flashplayer/include/marquee/design.swf?width=792&height=294
So just insert a query like "if(images[setPosition].indexOf('flashvars')>0)" and don't append '?'+flashvars later.
2) you want a .swf file to open in PrettyPhoto Iframe
- the script is checking for swf ending but if you give the parameters iframe=true it doesn't matter because it is already marked als flash.
possible solution: move the else if clause for Iframe just before the else if clause for flash. Otherwise the parameter given in URL is useless.
hope this helps some people.
BTW: Thanks for that awesome script - looking forward using the beta features
Kodachi
Howdy, Stranger!
It looks like you're new here. If you want to get involved, click one of these buttons!