Vanilla 2

Just tried to upgrade from 2.5.5 to 2.5.6 and ran into an issue with 2.5.6.

If you are calling $(element).prettyPhoto more than once on a page, the cached selectors will fail - you will get an error stating that '$ppt' is undefined.


In order to fix this, I believe you need to ensure that $ppt, $pp_pic_holder and $pp_overlay are always defined and initialized. The fix introduced in 2.5.6 for ajax reloads missed the case where prettyPhoto is executed twice on the same page - in this case $('.pp_overlay') exists so _buildOverlay() is not called, but it leaves $pp_pic_holder, $ppt and $pp_overlay uninitialized/undefined.


I've updated my local copy to cover this case. The following code exists in 2.5.6:

if($('.pp_overlay').size()==0) _buildOverlay(); // If the overlay is not there, inject it!

// Global variables accessible only by prettyPhoto
var doresize = true, percentBased = false, correctSizes,

// Cached selectors
$pp_pic_holder, $ppt, $pp_overlay,

// prettyPhoto container specific
pp_contentHeight, pp_contentWidth, pp_containerHeight, pp_containerWidth,


If updated to the following, it should take care of the undefined $ppt on multiple calls to .prettyPhoto on a single page:

// Cached selectors
var $pp_pic_holder, $ppt, $pp_overlay;

if($('.pp_overlay').size()==0) {
_buildOverlay(); // If the overlay is not there, inject it!
} else {
// ensure the cached selectors are initialized
$pp_pic_holder = $('.pp_pic_holder');
$ppt = $('.ppt');
$pp_overlay = $('div.pp_overlay');
}

// Global variables accessible only by prettyPhoto
var doresize = true, percentBased = false, correctSizes,

// prettyPhoto container specific
pp_contentHeight, pp_contentWidth, pp_containerHeight, pp_containerWidth,




BTW - great work on prettyPhoto, it's an awesome library!


Matt.